Skip to content

Add namespace to bug-8573.php / fix GenericsIntegrationTest#2147

Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
herndlm:fix-generics-integration-test
Dec 29, 2022
Merged

Add namespace to bug-8573.php / fix GenericsIntegrationTest#2147
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
herndlm:fix-generics-integration-test

Conversation

@herndlm
Copy link
Copy Markdown
Contributor

@herndlm herndlm commented Dec 27, 2022

makes the build green again.

the missing namespace lead to A and B leaking into other tests and messing up templates in GenericsIntegrationTest with the functions case.

the commit history on 1.9.x also shows that this was introduced with 630430f

@staabm
Copy link
Copy Markdown
Contributor

staabm commented Dec 28, 2022

@ondrejmirtes would be great if this fix could be merged. it fixes a build error in all open pull requests

@ondrejmirtes ondrejmirtes merged commit ab27d89 into phpstan:1.9.x Dec 29, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@herndlm herndlm deleted the fix-generics-integration-test branch December 29, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants