Skip to content

updated mb_convert_encoding mapping#213

Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom
marcu87:change-mb-convert-encoding
May 25, 2020
Merged

updated mb_convert_encoding mapping#213
ondrejmirtes merged 1 commit intophpstan:masterfrom
marcu87:change-mb-convert-encoding

Conversation

@marcu87
Copy link
Copy Markdown

@marcu87 marcu87 commented May 25, 2020

Issue reference: phpstan/phpstan#3336

mb_convert_encoding accepts array|string since php 7.2

https://www.php.net/manual/en/function.mb-convert-encoding.php

@ondrejmirtes
Copy link
Copy Markdown
Member

Maybe it could also be array<string>?

@ondrejmirtes
Copy link
Copy Markdown
Member

Never mind, I'll take it from here, we have to write a dynamic return type extension anyway :)

@ondrejmirtes ondrejmirtes merged commit 1508a00 into phpstan:master May 25, 2020
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@marcu87
Copy link
Copy Markdown
Author

marcu87 commented May 25, 2020

Thanks @ondrejmirtes :D

@ondrejmirtes
Copy link
Copy Markdown
Member

Done: a67c51c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants