Fix array casts as list type#1959
Conversation
|
For numeric, falsy, non-empty string, it's weird that the casted type is |
|
ok, it was not wrong, but intersection of two constant arrays narrowed to array type was the cause. |
bbb5298 to
aec17d9
Compare
|
Very weird only failing on windows... |
|
solved |
|
This pull request has been marked as ready for review. |
|
Noticed that failing tests of composer is caused from my previous PR 8b456c5 |
|
I think the composer failure is caused because of this I'm not sure why the composer integration test is running |
|
This pull request has been marked as ready for review. |
| foo((array) (fn () => 'closure')); | ||
| foo((array) $nonEmptyString); | ||
| foo((array) $nonFalsyString); | ||
| foo((array) $numericString); |
There was a problem hiding this comment.
The test code should be wrapped into a method or function (no top level code, when possible as it would get executed when running the testsuite)
There was a problem hiding this comment.
It's better to define parameter types as @param rather than @var.
|
fixed the tests and moved to CallMethodsRule |
|
I was taking literal-string wrong. |
|
Thank you! |
fixes array cast of types as list