Fix false positive of access to private property of parent class#1953
Fix false positive of access to private property of parent class#1953ondrejmirtes merged 4 commits intophpstan:1.9.xfrom
Conversation
|
according to the new bot, your PR would be closing 3 issues 🎉 https://github.com/phpstan/phpstan-src/actions/runs/3428507295 |
|
Please add regression tests for them too :) Thank you. |
|
When I get around to it, I'll add some smart commenting feature on PRs too. My idea is that when the bot finds changes, it adds a comment with them, but with further force-pushes, it doesn't add new comments, it just edits the first one. |
|
Perfect, thank you! |
|
@ondrejmirtes |
|
Don't worry, I always do that, that's what the bot is for 😊 |
|
@tyabu12 I am wondering whether we have the same problem in static context in https://phpstan.org/r/a757dd9c-01fa-450a-96f6-52a10feab73f |
|
@staabm |
|
here we go: phpstan/phpstan#8333 |
|
Thank you! |
fix phpstan/phpstan#2435