Add rule for casting objects to string#1948
Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom Nov 3, 2022
Merged
Conversation
ondrejmirtes
requested changes
Nov 1, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
I feel like we don't need a new rule here.
We need ObjectWithoutClassType::toString() to return ErrorType.
ObjectType already does this correctly.
Also, MixedType::toString() should be looked into for subtracted types.
728a2e1 to
c7ae23c
Compare
c7ae23c to
789a6c5
Compare
Member
|
Nice! I also love this error: |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule extracted from #1905 because it's useful without explicit
stringable-objectsupport as well