Skip to content

added operator-specifiying test for the pow-operator#1933

Merged
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
staabm:pow-test
Oct 30, 2022
Merged

added operator-specifiying test for the pow-operator#1933
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
staabm:pow-test

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Oct 28, 2022

coverage was missing for this single operators, as mentioned in #1904 (comment)

@staabm staabm marked this pull request as ready for review October 28, 2022 07:03
@phpstan-bot
Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ is XOR, POW is **.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my, nice catch. it means, we have 2 uncovered cases :).

added POW for real now

@ondrejmirtes ondrejmirtes merged commit 6cbcb68 into phpstan:1.9.x Oct 30, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@staabm staabm deleted the pow-test branch October 30, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants