Skip to content

Update deprecated set-output to $GITHUB_OUTPUT#1910

Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
samsonasik:update-set-output-to-github-output
Oct 25, 2022
Merged

Update deprecated set-output to $GITHUB_OUTPUT#1910
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
samsonasik:update-set-output-to-github-output

Conversation

@samsonasik
Copy link
Copy Markdown
Contributor

@ondrejmirtes ondrejmirtes merged commit 7377bb5 into phpstan:1.9.x Oct 25, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you :) Please do the same here: https://github.com/phpstan/phpstan/tree/1.9.x/.github/workflows

@samsonasik samsonasik deleted the update-set-output-to-github-output branch October 25, 2022 12:09
@ondrejmirtes
Copy link
Copy Markdown
Member

I'm sorry, I have to revert your changes, they break the workflow: https://github.com/phpstan/phpstan-src/actions/runs/3320826153/jobs/5487697232

@samsonasik
Copy link
Copy Markdown
Contributor Author

That's strange, seems working ok on rector-src rectorphp/rector-src@a59fd48 , probably missing quote somewhere ?

@ondrejmirtes
Copy link
Copy Markdown
Member

/cc @rez1dent3 do you have an idea? Thank you!

@rez1dent3
Copy link
Copy Markdown
Contributor

rez1dent3 commented Oct 25, 2022

@ondrejmirtes Previously, text escaping was required. Apparently it shot you off. In theory, in this case it is necessary to test separately.

actions/runner#2225
Need to follow the issue^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants