ignoreErrors fix reportUnmatched without path/paths#1773
Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom Sep 29, 2022
Merged
ignoreErrors fix reportUnmatched without path/paths#1773ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
Conversation
ondrejmirtes
requested changes
Sep 29, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Can you please also test array that just has message or messages? It should work at this point, and makes for more consistent formatting. Thanks.
e04715d to
4c3119b
Compare
Contributor
Author
|
It did not worked now but only because there were explicit check for it. So I removed it and added tests. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix of extended ignoreErrors - when reportUnmatched is used for message without path/paths it lead to ShouldNotHappen exception. Now this branch is valid and covered.
I also added few more tests for this feature.