Skip to content

encoding functions returns non-empty-string#1664

Merged
ondrejmirtes merged 3 commits intophpstan:1.8.xfrom
staabm:non-empty-encode
Sep 1, 2022
Merged

encoding functions returns non-empty-string#1664
ondrejmirtes merged 3 commits intophpstan:1.8.xfrom
staabm:non-empty-encode

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Aug 30, 2022

@staabm staabm marked this pull request as ready for review August 30, 2022 10:07
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Aug 31, 2022 •
edited
Loading

the error in composer is valid and it was there before this PR:

 ------ --------------------------------------------------------------------- 
  Line   src/Composer/Util/RemoteFilesystem.php                               
 ------ --------------------------------------------------------------------- 
  327    Parameter #1 $string of function base64_encode expects T of string,  
         string|false given.                                                  
 ------ ---------------------------------------------------------------------

since the error message changed because generics are involved now, the already existing ignore-line no longer mutes it

https://github.com/ondrejmirtes/composer/blob/acef69614d5c54def3418d3964749b49923200b2/phpstan/baseline-8.1.neon#L278-L281

ondrejmirtes
ondrejmirtes requested changes Sep 1, 2022
View reviewed changes
stubs/core.stub Outdated
Copy link
Copy Markdown
Member

@ondrejmirtes ondrejmirtes Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need generics for this, ($string is non-empty-string ? non-empty-string : string) should work just as well. Please edit all of these fuctions.

Copy link
Copy Markdown
Contributor Author

@staabm staabm Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed.

@staabm staabm mentioned this pull request Sep 1, 2022
Merged
@ondrejmirtes ondrejmirtes merged commit ca616c3 into phpstan:1.8.x Sep 1, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented Sep 1, 2022

Thank you!

@staabm staabm deleted the non-empty-encode branch September 1, 2022 09:54
Ocramius added a commit to lcobucci/jwt that referenced this pull request Sep 2, 2022
@Ocramius
Adjusted InMemoryTest to newest phpstan type inference improvements
15745b7 
Ref: https://github.com/phpstan/phpstan/releases/tag/1.8.3
Ref: phpstan/phpstan-src#1664
Ocramius added a commit to lcobucci/jwt that referenced this pull request Sep 2, 2022
@Ocramius
Adjusted InMemoryTest to newest phpstan type inference improvements
634bdf1 
Ref: https://github.com/phpstan/phpstan/releases/tag/1.8.3
Ref: phpstan/phpstan-src#1664
Horikawaer added a commit to Horikawaer/jwt that referenced this pull request Nov 3, 2022
@Horikawaer @Ocramius
Adjusted InMemoryTest to newest phpstan type inference improvements
95da7cc 
Ref: https://github.com/phpstan/phpstan/releases/tag/1.8.3
Ref: phpstan/phpstan-src#1664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@staabm @ondrejmirtes @clxmstaab