Simplify non-empty-array removal in array_push/array_unshift#1552
Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom Jul 26, 2022
Merged
Conversation
446a78c to
8806e4f
Compare
ondrejmirtes
requested changes
Jul 25, 2022
42aa916 to
2dbd086
Compare
2dbd086 to
20c533e
Compare
Contributor
Author
|
should be good, looks like the one composer failure is unrelated and happening in other PRs too. sorry for the pushes, wanted to double-check that :) |
Member
|
Thank you! This is the way to go - phase out the wrong way of doing things (remove it in places where it's not necessary), introduce a new better way, gradually, over many PRs :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous way I did that was just an overkill and hard to read. This is already the else branch that deals with generic arrays only. Since this just recently made problems it is luckily relatively well tested.