Merged
Conversation
Member
|
@herndlm I think there's gonna be something about this in |
ondrejmirtes
requested changes
Jul 11, 2022
Contributor
Author
I also don't think it's worth pursuing. I'd hope you'd say that 😅 |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I finally hit a small issue bot jackpot in #1493 that closes 5 more issues :)
Closes phpstan/phpstan#6781
Closes phpstan/phpstan#6647
Closes phpstan/phpstan#5896
Closes phpstan/phpstan#5474
Closes phpstan/phpstan#6000
phpstan/phpstan#5896 does still not report always false as mentioned, but I think that's a different problem. See e.g. https://phpstan.org/r/416a6ec2-aa3c-4b01-858a-1bfed84bd797, as this was not part of the original issue there, should a new one be opened? not sure if phpstan is able to keep track of such variable copies or clones?