Fix Identical type specification of constant types#1493
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Jul 10, 2022
Merged
Fix Identical type specification of constant types#1493ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
Conversation
ondrejmirtes
requested changes
Jul 10, 2022
Member
|
Thank you very much! |
Member
|
There are bunch of code examples in current issues where the results changed because of this PR:
Can you please go through them and see:
Thank you very much! |
Contributor
Author
|
Looking good, do you have preferences in the regression tests? All in one PR/commit OK? Looks like I'll also have to create two tests for an issue or two. |
Member
|
Each closed issue should have a separate test case, meaning |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7257
This was not working correctly because e.g. a
ConstantArrayTypecannot be safely used to strictly specify the other (left or right) type in the Identical comparison without further checks.The problem with the linked issue was that it would have the same types on the left and right side and basically cancel out the types in a falsey scope (the right side of the
||for e.g.$sortedleading to aNeverType), see https://phpstan.org/r/f560aac6-602f-45a0-8115-bb94f7142f79. Which explains why it works if only truthy scopes (via variable assignments) work around that.