Run with parallel runner only when proc_open is not disabled#1451
Merged
ondrejmirtes merged 2 commits intophpstan:1.7.xfrom Jun 22, 2022
Merged
Run with parallel runner only when proc_open is not disabled#1451ondrejmirtes merged 2 commits intophpstan:1.7.xfrom
proc_open is not disabled#1451ondrejmirtes merged 2 commits intophpstan:1.7.xfrom
Conversation
Member
|
I can't merge this change, it's basically a revert of a previous commit where I did this on purpose so that fatal errors happen in subprocesses and PHPStan still finishes with a nice outpur. |
Contributor
Author
|
No problem, I will update the condition to check explicitly for |
184f27a to
f4a0685
Compare
proc_open is not disabled
f4a0685 to
1687bcf
Compare
1687bcf to
6287d7b
Compare
Member
|
Thank you. Please open a new PR with an integration test in phpstan/phpstan. Do not modify an existing test but add a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#7488
phpstan already accounts for disabled
proc_openwhen detecting available CPU cores