Test phpstan /w restricted php.ini conf#7488
Closed
mvorisek wants to merge 1 commit intophpstan:1.7.xfrom
mvorisek:test_no_proc_open
Closed
Test phpstan /w restricted php.ini conf#7488mvorisek wants to merge 1 commit intophpstan:1.7.xfrom mvorisek:test_no_proc_open
mvorisek wants to merge 1 commit intophpstan:1.7.xfrom
mvorisek:test_no_proc_open
Conversation
Contributor
Author
|
@ondrejmirtes test should be working, but for some reasons, the original code is run |
Member
|
You get a nice error message: This behaviour is expected. There's no reason to disable these functions in the environment where you want to run PHPStan. |
Contributor
Author
|
No, it the "detect CPU cores" code already account for that and it was working. But it was broken with some recent release. In some environments, |
Contributor
Author
|
@ondrejmirtes please reopen this PR, I will try to fix the issue, it worked before and phpstan should continue to work /w that php.ini configuration |
Member
|
You can send a PR with a fix to phpstan-src and link this closed PR once you think it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test #4147 and also disabled
proc_open(which imply no parallelization possible)probably no need to run full phpstan with these configurations