NeonAdapter: throw more meaningful error which contains the filename#136
Merged
ondrejmirtes merged 4 commits intophpstan:masterfrom Feb 8, 2020
Merged
NeonAdapter: throw more meaningful error which contains the filename#136ondrejmirtes merged 4 commits intophpstan:masterfrom
ondrejmirtes merged 4 commits intophpstan:masterfrom
Conversation
staabm
reviewed
Feb 8, 2020
| try { | ||
| return $this->process((array) Neon::decode($contents), '', $file); | ||
| } catch (\Nette\Neon\Exception $e) { | ||
| throw new \Nette\Neon\Exception(sprintf('Error while loading %s: %s', $file, $e->getMessage())); |
Contributor
There was a problem hiding this comment.
We could add $e as the previousException.. not sure we need this though
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this change a error looks like
after this change we get a error message which also contains the actual path to the neon-file which contains the error.. its not always the one which gets passed by cli arg :)