Fix/issue 3171 dynamic properties#1237
Merged
ondrejmirtes merged 6 commits intophpstan:1.6.xfrom Apr 22, 2022
Merged
Conversation
Contributor
Author
|
The |
Member
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#3171 completly
The error was suppressed by #1234
but still happening if
checkDynamicPropertiesis enabled.https://phpstan.org/r/7092e4dc-cfed-4fcf-810a-7ad5e3b9555e
It is because,
ensureNonNullabilitywas not traversing onArrayDimFetch. d450536.Also, I think the logic for
ensureNonNullabilityandallowedUndefinedExpressionshould be consistent with each other, so refactoredensureNonNullabilityby usinglookForExpressionCallback.As I mentioned in a624060
there is one more possible false positive, property fetch on
Class|false(or something likefalsethat doesn't accept fetching properties), but I think it is too complicate to solve now.When property fetch is called inside isset, the isset truthy scope is more specific than non-null, it can say "the fetched var has a
!hasProperty->no()type". Similar type specification is possible inArrayDimFetchtoo. (adding this level of specification can solve issues like phpstan/phpstan#7073, but maybe too much)