Skip to content

Add non regression tests for #3951 and #6845 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Mar 23, 2022
Merged

Add non regression tests for #3951 and #6845 #1106

ondrejmirtes merged 1 commit into from
Mar 23, 2022

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Mar 22, 2022

@VincentLanglet VincentLanglet marked this pull request as ready for review March 22, 2022 18:50
@VincentLanglet VincentLanglet mentioned this pull request Mar 22, 2022
Merged
@ondrejmirtes ondrejmirtes merged commit 9a231fc into phpstan:1.5.x Mar 23, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Mar 23, 2022

Thank you!

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Mar 23, 2022

I have two more if you feel like it :) phpstan/phpstan#6576 + phpstan/phpstan#6842

The #6842 one should be in AnalyserIntegrationTest.php.

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Mar 26, 2022

phpstan/phpstan#6576 + phpstan/phpstan#6842

Done #1121

@VincentLanglet VincentLanglet deleted the regressionTests branch March 26, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intersection type info being lost on templated function Phpstan complains that a method returns a child where it expected a parent

2 participants

@VincentLanglet @ondrejmirtes