Add non regression tests for phpstan/phpstan#6576 + phpstan/phpstan#6842 #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccd3a84 to
ca9bc8c
Compare
ca9bc8c to
5cd1eef
Compare
Contributor
|
Please reference the relevant issues in the PR description like |
Contributor
Author
|
Closes phpstan/phpstan#6576 But they are already closed |
Contributor
|
Even if they are already closed - adding the link - will show up a reference at the issue. So it eases getting things together later on. |
Member
|
Awesome, thank you. |
Contributor
Author
I can do more if you need to :) |
Member
|
I'll keep that in mind when it happens next time - when some bugs are fixed as a side effect of another fix and @phpstan-bot discovers that 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6576
Closes phpstan/phpstan#6842