Add non regression test for issue 5336 #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Mar 22, 2022
Member
There was a problem hiding this comment.
- Please just do
assertType('Bug5336\Pager<Bug5336\ProxyQueryInterface&Bug5336\Stub>', new Pager($query));. Assigningnewto properties has some extra behaviour that might hide bugs here. - Please create another test for TypesAssignedToPropertiesRuleTest that actually shows that assignment to property no longer reports an error. If you're gonna use classes with the same names, change the namespace name slightly, like
Bug5336Ruleor something.
Member
|
Awesome, thank you! Can you please also send regression tests for phpstan/phpstan#3951 and phpstan/phpstan#6845? It'd mean a lot to me, thanks. Please also add "Closes #XY" in the body of the PR. |
Contributor
Author
|
Sure, I opened #1106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.