Skip to content

Allow null as a return value when resolving return types #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Mar 10, 2022
Merged

Allow null as a return value when resolving return types #1061

ondrejmirtes merged 1 commit into from
Mar 10, 2022

Conversation

@matthiasnoback
Copy link
Contributor

@matthiasnoback matthiasnoback commented Mar 10, 2022

This fixes an issue reported earlier: phpstan/phpstan#5855

Please let me know if you want me to provide anything else at this point.

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Mar 10, 2022

It's technically a BC break but I doubt that anyone calls these directly:


[BC] CHANGED: The return type of PHPStan\Type\DynamicFunctionReturnTypeExtension#getTypeFromFunctionCall() changed from PHPStan\Type\Type to the non-covariant ?PHPStan\Type\Type
[BC] CHANGED: The return type of PHPStan\Type\DynamicFunctionReturnTypeExtension#getTypeFromFunctionCall() changed from PHPStan\Type\Type to ?PHPStan\Type\Type
[BC] CHANGED: The return type of PHPStan\Type\DynamicMethodReturnTypeExtension#getTypeFromMethodCall() changed from PHPStan\Type\Type to the non-covariant ?PHPStan\Type\Type
[BC] CHANGED: The return type of PHPStan\Type\DynamicMethodReturnTypeExtension#getTypeFromMethodCall() changed from PHPStan\Type\Type to ?PHPStan\Type\Type
[BC] CHANGED: The return type of PHPStan\Type\DynamicStaticMethodReturnTypeExtension#getTypeFromStaticMethodCall() changed from PHPStan\Type\Type to the non-covariant ?PHPStan\Type\Type
[BC] CHANGED: The return type of PHPStan\Type\DynamicStaticMethodReturnTypeExtension#getTypeFromStaticMethodCall() changed from PHPStan\Type\Type to ?PHPStan\Type\Type

@ondrejmirtes ondrejmirtes merged commit a897d3a into phpstan:master Mar 10, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Mar 10, 2022

Thank you!

@ondrejmirtes ondrejmirtes mentioned this pull request Mar 10, 2022
Closed
@matthiasnoback
Copy link
Contributor Author

matthiasnoback commented Mar 10, 2022

It's technically a BC break

Never saw that tool being used, seems very useful!
Right, as you mentioned earlier, for implementers it's no issue, but for clients it could be.

Thanks for the quick merge!

I think it would be nice to update the documentation about type extensions as well: instead of always returning a type using the default selectFromArgs() call you can now return null if you don't have a specific type. Can I do that? Should this happen on the phpstan/phpstan repository?

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Mar 10, 2022

Yes, documentation pages have "Edit this page" link at the bottom 😊 Please don't forget to mention that "null" can be used since PHPStan 1.5.0. (I'll merge it after the release which is gonna be in a few weeks).

matthiasnoback added a commit to matthiasnoback/phpstan that referenced this pull request Mar 10, 2022
@matthiasnoback
Document optional return type for dynamic return type extensions
aa0903f 
See phpstan/phpstan-src#1061
@matthiasnoback matthiasnoback mentioned this pull request Mar 10, 2022
Merged
ondrejmirtes pushed a commit to phpstan/phpstan that referenced this pull request Mar 24, 2022
@matthiasnoback @ondrejmirtes
Document optional return type for dynamic return type extensions
263ac19 
See phpstan/phpstan-src#1061
@herndlm herndlm mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthiasnoback @ondrejmirtes