Skip to content

Fix #1968.#1970

Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom
ADmad:patch-1
Mar 11, 2019
Merged

Fix #1968.#1970
ondrejmirtes merged 1 commit intophpstan:masterfrom
ADmad:patch-1

Conversation

@ADmad
Copy link
Copy Markdown
Contributor

@ADmad ADmad commented Mar 11, 2019

No description provided.

@ADmad
Copy link
Copy Markdown
Contributor Author

ADmad commented Mar 11, 2019

Based on the docblock for this file it seems both phpstan and psalm have copied this function map file from phan to begin with.

It would be great if all three projects could come up with a way to keep their copies in sync so fixes submitted to one could benefit users of all the 3 tools. Personally I have submitted a handful of updates to psalm's callmap file.

/cc @muglug

@muglug
Copy link
Copy Markdown
Contributor

muglug commented Mar 11, 2019

@ADmad Psalm syncs on a monthly-ish basis with the file that @TysonAndre maintains upstream, but PHPStan doesn’t AFAIK. Psalm’s fork is here: https://github.com/psalm/PHPSignatures

@ADmad
Copy link
Copy Markdown
Contributor Author

ADmad commented Mar 11, 2019

@muglug Good to hear. I hadn't noticed your fork. Thanks!

@ondrejmirtes
Copy link
Copy Markdown
Member

Thanks!

@ondrejmirtes ondrejmirtes merged commit 4be0c76 into phpstan:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants