eval function can throw exceptions
#5353
-
|
If the Is there a way to fix this or should I just ignore the error? (This can probably apply to other functions as well) |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
i guess And have an implicit throw point added like it's done for example for YieldFrom here: https://github.com/phpstan/phpstan-src/blob/dca48f34bcec87971ceaa4643eef02ed9b2fd812/src/Analyser/NodeScopeResolver.php#L2367 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you. I'll try to prepare a PR in the following days. |
Beta Was this translation helpful? Give feedback.
-
|
@canvural I'm just throwing a reminder about this out here :) If you could look into it I'd appreciate it! |
Beta Was this translation helpful? Give feedback.
i guess
Eval_needs to be separate into its ownelseifbranch here: https://github.com/phpstan/phpstan-src/blob/dca48f34bcec87971ceaa4643eef02ed9b2fd812/src/Analyser/NodeScopeResolver.php#L2350-L2364And have an implicit throw point added like it's done for example for YieldFrom here: https://github.com/phpstan/phpstan-src/blob/dca48f34bcec87971ceaa4643eef02ed9b2fd812/src/Analyser/NodeScopeResolver.php#L2367