feat: allow symfony 7#1452
Closed
Chris53897 wants to merge 2 commits intophpspec:mainfrom
Chris53897:feature/allow-symfony-7
Closed
feat: allow symfony 7#1452Chris53897 wants to merge 2 commits intophpspec:mainfrom Chris53897:feature/allow-symfony-7
Chris53897 wants to merge 2 commits intophpspec:mainfrom
Chris53897:feature/allow-symfony-7
Conversation
|
Symfony 7 has been released. @ciaranmcnulty can we move forward with this PR? |
This was referenced Nov 29, 2023
Contributor
|
@ciaranmcnulty @MarcelloDuarte @stof |
74 tasks
Beninho
approved these changes
Dec 4, 2023
Contributor
|
@Chris53897 Please, could you fix the issues (cf CI)? |
Contributor
Author
|
The ci (Psalm) error, are not related to this PR, and should be fixed in an seperate PR in my eyes. |
Contributor
Author
|
See https://github.com/Chris53897/phpspec/actions/runs/7214166989 for example |
Member
|
Thanks for this @Chris53897 I'm closing only because #1454 is more complete, I'll credit you in the changelog |
96 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if the ci testruns already covers symfony 7 installation