Merged
Conversation
|
Hi @thecrimpmaster - could you please address the static analysis issues? |
2a37860 to
7c38d1e
Compare
Contributor
Author
|
Sorry, I just kind of created, pushed, and didn't check back due to time constraints. Made some changes and all builds passing now. Probably worth a review or two, as not sure about all changes |
thecrimpmaster
commented
Jan 18, 2024
|
|
||
| - name: Run tests (phpunit) | ||
| run: ./vendor/bin/phpunit -v | ||
| run: ./vendor/bin/phpunit |
Contributor
Author
There was a problem hiding this comment.
Verbose option has been removed in version 10 (https://github.com/sebastianbergmann/phpunit/blob/10.0.0/ChangeLog-10.0.md)
Is this ok to just remove it?
| """ | ||
| - 'i' => 1 | ||
| """ | ||
| And I should see: |
Contributor
Author
There was a problem hiding this comment.
There seems to be an "," added to the diff message in php 8. I've split the expectations out to pass in 7 and 8. Feels slightly clunky. Love to hear others' opinions
Closed
Member
|
Thanks @thecrimpmaster ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.