Fix #17553 - [Metro] Unreadable links and UI fixes/improvements#17665
Fix #17553 - [Metro] Unreadable links and UI fixes/improvements#17665williamdes merged 8 commits intophpmyadmin:QA_5_2from
Conversation
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
Signed-off-by: Andrea Falcon <falcon.andrea88@gmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi @MauricioFauth |
williamdes
left a comment
There was a problem hiding this comment.
Again I want to say a big thank you for this pull-request !
It's very good work for a first time in open-source !! 🎉
It took way too long for me to review this one in depth, sorry for that :/
The points I reviewed:
changed background-color to the alert box in /server/databases route for better readability
Perfect !
removed button styles from the print link in database pages and lock link in user accounts page for unify styles with other links
Very good !
changed hover styles on buttons, for example Drop button in /server/databases route (where I changed also the icon with the white color version)
Way better in white !
Good work on the login page too !
I reverted the change made for the modal close button as it is worse now that fixes where made for it as I said on #17553
Description
Fix bugs reported in issue #17553.
I made some additional CSS fix
I hope it is all correct. This is my first Pull Request on OpenSource World :)