Fix ReflectionMethod signatures for appendByKey,prepend, etc.#352
Merged
sodabrew merged 1 commit intophp-memcached-dev:masterfrom Jun 9, 2017
Merged
Conversation
sodabrew
approved these changes
Jun 9, 2017
Collaborator
sodabrew
left a comment
There was a problem hiding this comment.
You're right - and the memcached protocol explicitly states that expiration is ignored for append/pretend if it is given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memc_store_impl suggests that the prepend family expects exactly 3 arguments for prependByKey(), 2 for prepend(). memcached-api.php already has the correct counts (3 for byKey, 2 for plain)
Example snippet showing the bug:
(new ReflectionMethod('Memcached', 'prepend'))->getNumberOfParameters()was wrong as a result of this. It should be 2, but was 3.