Modified Keywords code sample contains parse errors#73
Merged
Crell merged 1 commit intophp-fig:masterfrom May 5, 2023
Merged
Conversation
* The `static` and `readonly` modifiers for properties are, at the time of writing, mutually exclusive, which makes the first property example a parse error. * `final` properties are not a thing in PHP, which makes the second property example a parse error. This commit fixes both code examples. While I can appreciate that the code sample _intends_ to show an example where all possible modifier keywords + type declarations are used, I do not believe that showing this via code which isn't valid PHP to begin with, is helpful. Introduced in 19.
samdark
approved these changes
May 4, 2023
Collaborator
|
A valid point, but to me that means we shouldn't just change the examples, but add more. Like, "public static string $foo", "public readonly string $bar", etc. Let's show several different valid permutations. (Valid both by PHP and the PER.) Can you update? |
Contributor
Author
It already does and is also, why I changed The combined examples in that whole section now show all possible modifiers in use within valid PHP code. |
Collaborator
|
Ah, that's what I get for not expanding the diff... 😛 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
staticandreadonlymodifiers for properties are, at the time of writing, mutually exclusive, which makes the first property example a parse error.finalproperties are not a thing in PHP, which makes the second property example a parse error.This commit fixes both code examples.
While I can appreciate that the code sample intends to show an example where all possible modifier keywords + type declarations are used, I do not believe that showing this via code which isn't valid PHP to begin with, is helpful.
Introduced in #19.