Update the abstract/final section to cover all modifier keywords#19
Merged
KorvinSzanto merged 3 commits intophp-fig:masterfrom Jul 17, 2022
Merged
Update the abstract/final section to cover all modifier keywords#19KorvinSzanto merged 3 commits intophp-fig:masterfrom
KorvinSzanto merged 3 commits intophp-fig:masterfrom
Conversation
samdark
approved these changes
Jun 2, 2022
KorvinSzanto
reviewed
Jun 9, 2022
KorvinSzanto
reviewed
Jun 9, 2022
Co-authored-by: Korvin Szanto <Korvinszanto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers a couple of new additions:
readonly, typed properties, etc. Because there's so many, it made sense to me to repurpose the abstract/final/static section to cover the full list, in order.This may overlap now with section 4.4. If so, I recommend agreeing on the rules (this PR), then we can refactor the spec text to be better chunked if needed.