Undo capitalization of // no break to prevent tooling issues#113
Merged
Crell merged 1 commit intophp-fig:masterfrom May 13, 2025
Merged
Undo capitalization of // no break to prevent tooling issues#113Crell merged 1 commit intophp-fig:masterfrom
// no break to prevent tooling issues#113Crell merged 1 commit intophp-fig:masterfrom
Conversation
In [PR 79](php-fig#79) all comments where either replaced with ellipsis or capitalized. The `// no break` comment however is used literally in various tools and capitalizing this might lead to tooling regressions.
lpd-au
approved these changes
May 13, 2025
Crell
approved these changes
May 13, 2025
Contributor
|
For the record: the WordPress Coding Standards just look for a comment without a predefined contents. Quoting that as a reference to justify this change is not correct and shows this hasn't been validated/tested. |
Contributor
The spec likewise only requires a comment, all this PR did was revert an unpublished change to the example (so it once again matches WordPress' example and works with PhpStorm + other tools). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR 79 all comments where either replaced with ellipsis or capitalized. The
// no breakcomment however is used literally in various tools and capitalizing this might lead to tooling regressions.For reference, literal
// no breakseems to be a de-facto standard, even if it is not explicitly phrased as such: