Skip to content

Conversation

@Runster
Copy link
Contributor

@Runster Runster commented Jul 1, 2016

Hello,

I've fixed a small bug:

The current bug type will be displayed after changing the select box (stats.php).

php-pulls pushed a commit that referenced this pull request Dec 12, 2016
Committer's note: I rewrote this from the original PR
at #23 for three reasons:
1. The preceeding code usually case folded $current,
   but may not depending on the value of $all and $current.
   This was likely the source of the original issue being addressed.
   By using strcasecmp(), the comparison no longer cares about case.
2. While $bug_types is *probably* safe to output unescaped,
   it makes sense to be defensive and add some output protection.
3. Readability

-Sara
@php-pulls
Copy link

Comment on behalf of pollita at php.net:

Pushed as 21f5fd3
Note that the final version of this commit is radically different from the proposed PR.

@php-pulls php-pulls closed this Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants