Skip to content

Fix mysql tests with non-standard server port#9744

Closed
mvorisek wants to merge 1 commit intophp:PHP-8.1from
mvorisek:del_bug72858_test
Closed

Fix mysql tests with non-standard server port#9744
mvorisek wants to merge 1 commit intophp:PHP-8.1from
mvorisek:del_bug72858_test

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Oct 14, 2022 •
edited
Loading

No description provided.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Oct 14, 2022

The test passes locally for me (PHP-8.0 and PHP-8.1; on PHP-8.2 and master it fails for different reasons, likely due to #8648; I'm going to check that).

Anyway, the actual value of $v2 does not really matter; the bug fix (and the regression test) are only there to check that a failing MapViewOfFileEx() is properly caught. So could you please try with $v2 = PHP_INT_MAX instead of the assignment we have now?

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Oct 14, 2022

on PHP-8.2 and master it fails for different reasons, likely due to #8648; I'm going to check that

See #9748.

@mvorisek mvorisek changed the title Delete always failing sysvshm bug72858.phpt test Fix always failing sysvshm bug72858.phpt test Oct 14, 2022
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Oct 14, 2022 •
edited
Loading

Anyway, the actual value of $v2 does not really matter; the bug fix (and the regression test) are only there to check that a failing MapViewOfFileEx() is properly caught. So could you please try with $v2 = PHP_INT_MAX instead of the assignment we have now?

it matters :), tested in https://github.com/php/php-src/actions/runs/3249858369/jobs/5332750729#step:8:4628, test is no longer failing, PR title updated

mvorisek added a commit to mvorisek/php-src that referenced this pull request Oct 14, 2022
@mvorisek
Fix always failing sysvshm bug72858.phpt test - cherrypick phpGH-9744
349d2dd
@mvorisek mvorisek changed the title Fix always failing sysvshm bug72858.phpt test Make tests compatible with Windows x86 builds Oct 14, 2022
@mvorisek mvorisek mentioned this pull request Oct 14, 2022
Closed
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
@mvorisek mvorisek marked this pull request as draft October 14, 2022 18:30
mvorisek added a commit to mvorisek/php-src that referenced this pull request Oct 14, 2022
@mvorisek
fix other tests for Windows x86 build - phpGH-9744
db714b3
@mvorisek mvorisek marked this pull request as ready for review October 14, 2022 18:45
@mvorisek mvorisek changed the base branch from PHP-8.0 to PHP-8.1 November 12, 2022 14:07
mvorisek added a commit to mvorisek/php-src that referenced this pull request Nov 12, 2022
@mvorisek
Fix always failing sysvshm bug72858.phpt test - cherrypick phpGH-9744
6db6dc1
mvorisek added a commit to mvorisek/php-src that referenced this pull request Nov 12, 2022
@mvorisek
fix other tests for Windows x86 build - phpGH-9744
3fa8a73
mvorisek added a commit to mvorisek/php-src that referenced this pull request Nov 13, 2022
@mvorisek
fix other tests for Windows x86 build - phpGH-9744
9bd8657
mvorisek added a commit to mvorisek/php-src that referenced this pull request Nov 13, 2022
@mvorisek
fix other tests for Windows x86 build - phpGH-9744
cd93dee
@mvorisek mvorisek requested a review from cmb69 November 13, 2022 12:02
@mvorisek mvorisek marked this pull request as draft November 15, 2022 12:34
@mvorisek mvorisek mentioned this pull request Feb 22, 2023
Closed
@mvorisek mvorisek force-pushed the del_bug72858_test branch from d99c4c0 to 9c8a358 Compare April 18, 2023 08:33
@mvorisek mvorisek changed the title Make tests compatible with Windows x86 builds Fix mysql tests with non-standard server port Apr 19, 2023
@mvorisek mvorisek marked this pull request as ready for review April 19, 2023 11:05
@mvorisek mvorisek force-pushed the del_bug72858_test branch from 9c8a358 to 415bd75 Compare April 19, 2023 11:06
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Apr 19, 2023

This PR is complete, other changes to fix tests for Windows CI has been already integrated.

@iluuu1994 iluuu1994 closed this in 0ab51a9 Apr 20, 2023
@iluuu1994
Copy link
Copy Markdown
Member

iluuu1994 commented Apr 20, 2023

Looks fine, thanks!

@mvorisek mvorisek deleted the del_bug72858_test branch April 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 Awaiting requested review from cmb69

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvorisek @cmb69 @iluuu1994