Skip to content

Test Windows x86 and x64 with Github Actions#8392

Closed
mvorisek wants to merge 16 commits intophp:PHP-8.1from
mvorisek:win_ci.cipush
Closed

Test Windows x86 and x64 with Github Actions#8392
mvorisek wants to merge 16 commits intophp:PHP-8.1from
mvorisek:win_ci.cipush

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Apr 17, 2022 •
edited
Loading

Move Windows testing to unified place - GitHub Actions

needs #9721 and #9744

AppVeyour (orig):
image

Github Actions (moved):
image

@mvorisek mvorisek force-pushed the win_ci.cipush branch 2 times, most recently from b465468 to 69f7c7b Compare April 17, 2022 19:43
cmb69
cmb69 reviewed Apr 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving Windows CI to GH actions is very welcome. Thank you! @flavioheleno and @iluuu1994 already worked on that; not sure what's the status of that.

Anyhow, I suggest to keep AppVeyor CI for a while, so we can verify that the move is complete.

@iluuu1994
Copy link
Copy Markdown
Member

iluuu1994 commented Apr 18, 2022

I started but didn't get very far. iluuu1994#10 I'm happy for anybody else to take over.

@flavioheleno
Copy link
Copy Markdown
Contributor

flavioheleno commented Apr 18, 2022

I haven't gone too far either. Changes are here: flavioheleno@0ee6bc5 :-)

@mvorisek mvorisek changed the base branch from master to PHP-8.0 April 18, 2022 13:41
@mvorisek mvorisek force-pushed the win_ci.cipush branch 6 times, most recently from 49336d0 to 4da833f Compare April 18, 2022 15:30
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Apr 18, 2022

🚀 🚀 tests run!

guys, can you take care of the failing tests?

also, x86 cannot compile :(

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Apr 18, 2022

guys, can you take care of the failing tests?

On a very quick glance, this looks like a line ending issue. It might be necessary to checkout with LF.

also, x86 cannot compile :(

The CI runs with CFLAGS=/W1 /WX. So far, this is only supported for x64. I suggest to just run with CFLAGS=/W1 instead for now.

@mvorisek mvorisek force-pushed the win_ci.cipush branch 5 times, most recently from 47c8c69 to 874ba42 Compare April 18, 2022 16:48
@mvorisek mvorisek marked this pull request as ready for review April 18, 2022 16:56
@mvorisek mvorisek force-pushed the win_ci.cipush branch 3 times, most recently from ab66b78 to 49c9870 Compare April 18, 2022 19:59
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Apr 18, 2022

what is wrong with 59e357a? previous commit has no issue, but if the if is removed, build fails with command syntax error

@iluuu1994
Copy link
Copy Markdown
Member

iluuu1994 commented Apr 18, 2022 •
edited
Loading

The condition isn't the same, maybe that's it?

Ah sorry, you actually removed the outer if. Are you sure the first if was even executed before? Anyway, sorry I can't really help here, I'm not very familiar with the Windows build process.

@mvorisek mvorisek force-pushed the win_ci.cipush branch 4 times, most recently from ae467dd to e5e678a Compare April 19, 2022 13:08
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Apr 22, 2022

@cmb69 can you please help me with the one failing Windows test?

@mvorisek mvorisek force-pushed the win_ci.cipush branch 6 times, most recently from ae3844d to 4c16ad3 Compare October 12, 2022 06:12
This was referenced Oct 13, 2022
Closed
Closed
mvorisek
mvorisek commented Oct 14, 2022
View reviewed changes
.github/workflows/push.yml
- '**'
jobs:
LINUX_X64:
if: false
Copy link
Copy Markdown
Contributor Author

@mvorisek mvorisek Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST BE REVERTED BEFORE MERGE

@mvorisek mvorisek mentioned this pull request Oct 14, 2022
Closed
@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Oct 14, 2022

Hello, PR is passing CI, please let me know if there is anything to address

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 19, 2023

There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken.

@iluuu1994 iluuu1994 mentioned this pull request Feb 22, 2023
Closed
@iluuu1994
Copy link
Copy Markdown
Member

iluuu1994 commented Feb 22, 2023

@mvorisek Thank you for this PR! I opened #10664 with a minimal set of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 requested changes

Assignees

No one assigned

Labels

Category: Tests OS: Windows Waiting on Author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mvorisek @iluuu1994 @flavioheleno @cmb69 @Girgias @ramsey