Declare tentative return types in ext/spl - part 3#7239
Declare tentative return types in ext/spl - part 3#7239kocsismate merged 2 commits intophp:masterfrom
Conversation
b8642db to
5dea01e
Compare
3894122 to
8eb0e76
Compare
|
Help! It may just be me being stupid and doing something wrong, but adding the attribute to methods implementing the Iterator interfaces does not seem to work. I've done similar PRs elsewhere for other interfaces already and they all fixed the issues, but not for the Iterators. Please do let me know if you'd rather I open a bug report at bugs.php.net. This is where the issue can be seen:
|
|
@jrfnl I think your patch is just missing a |
|
@jrfnl I think it'd be best if you file a proper bug report on bugs.php.net. A comment here might get lost or forgotten. |
Cricky! Of course... Duh! Trying to think back now, but yes, I think the other patches I submitted for these types of things were all in non-namespaced projects ;-) (Yeah, don't get me started, but that's another issue) |
|
Confirmed: adding the |
No description provided.