Skip to content

Conversation

@davisinfo
Copy link

Fix #78987 - Memory problems running finfo::buffer

  • applied the original patch from the file library

@Girgias
Copy link
Member

Girgias commented Jun 23, 2021

Duplicate of #7187

@Girgias Girgias marked this as a duplicate of #7187 Jun 23, 2021
@Girgias Girgias closed this Jun 23, 2021
@cmb69 cmb69 reopened this Jun 24, 2021
@cmb69 cmb69 added the Bug label Jun 24, 2021
@cmb69
Copy link
Member

cmb69 commented Jun 24, 2021

Could you please fix the failing test?

@davisinfo
Copy link
Author

I’ll look into it

@it-can
Copy link

it-can commented Jul 29, 2021

Any news on this?

@davisinfo
Copy link
Author

Sorry, I didn’t forget but it was a busy period. I’ll work on it in the next days.

@davisinfo
Copy link
Author

@cmb69 @it-can spaces and failing test fixed

@cmb69
Copy link
Member

cmb69 commented Aug 4, 2021

@weltling, what do you think?

@weltling
Copy link
Contributor

@cmb69 the submitted patch doesn't seem appropriate for 7.4, a test is missing and there's a lot of unrelated white space change.

@davisinfo appreciate your efforts to fix this. May i suggest this:

  • Backport only the essential part by resetting the length to 64K in file_encoding().
  • Convert two user supplied scripts from the bug entry into tests.
  • Update patch.

I might have time to fix this closer to next week or alike, there still seems to be room for this change to get into 7.4.

Thanks

@weltling
Copy link
Contributor

Backported the upstream solution in fa96c7e.

Thanks.

@weltling weltling closed this Sep 19, 2021
@seanm
Copy link

seanm commented Oct 12, 2021

Is this fix in 7.4.24 or not yet in a public 7.4.x release?

@seanm
Copy link

seanm commented Oct 26, 2021

To answer my own question: looks like it's in the 7.4.25 release notes! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants