Skip to content

Conversation

@davisinfo
Copy link

@davisinfo davisinfo commented Jun 23, 2021

Fix #78987 - Memory problems running finfo::buffer

  • applied the original patch from the file library

@cmb69
Copy link
Member

cmb69 commented Jun 23, 2021

Thank you for the PR! That doesn't look like a security issue, though, and as such is not eligible for PHP-7.3; the patch should target PHP-7.4. Furthermore, these changes need to be integrated into libmagic.patch. Plus, there should be a regression test.

cc @weltling

@davisinfo
Copy link
Author

davisinfo commented Jun 23, 2021

@cmb69 there was one that targeted PHP-7.4 but @Girgias closed it #7188

From what I saw the libmagic.patch is not used automatically during the compilation but just manually when you use the generate_patch.sh to grab a new version of the source files from the file library

This PR only includes the changes specific to this bug, but on master the files were updated to the ones from the latest version of the files, we could do that also if that is desired.

@cmb69
Copy link
Member

cmb69 commented Jun 24, 2021

@cmb69 there was one that targeted PHP-7.4 but @Girgias closed it #7188

Okay, so I close this and re-open the other.

From what I saw the libmagic.patch is not used automatically during the compilation but just manually when you use the generate_patch.sh to grab a new version of the source files from the file library

Right. It still can make sense to update libmagic.patch, to be able to see what we changed compared to the original version. Not really sure how that has been handled so far.

@cmb69 cmb69 closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants