Fixed bug #61546 functions related to current script failed when chdir() in cli sapi #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, you should not call to tsrm_realpath even the scriptname is "-", just some lines above it there is the obvious codes to set filename to '-', didn't you see it? Any, I Committed a little improved patch. thanks |
|
Comment on behalf of laruence at php.net: Closed |
Contributor
Author
|
oh, that's the truth. I didn't noticed that. |
Member
|
On Mon, Apr 30, 2012 at 12:38 PM, reeze
anyway, thanks for spotting this. committed here: thanks
惠新宸 laruence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in cli sapi SG(request_info).path_translated is relative path. when chdir it will point to non-exists file.
in fastcgi and fpm they all point to absolute path. so I made this push request to fix this.
this bug affect get_current_user(), getmyinode() and getlastmod().
thanks.