Fix #69668: SOAP special XML characters in namespace URIs not encoded #6804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xmlNewNs()` does not XML encode the passed `href`, so we need to do that manually.
nikic
approved these changes
Mar 25, 2021
Member
nikic
left a comment
There was a problem hiding this comment.
Looks reasonable, though I guess there's a risk that someone was working around the previous behavior with manual escaping.
Member
Author
|
At least regarding the bug report that was not possible, because the namespace URI was part of the WSDL, unescaped during read and written back as is. But there might be cases where manual escaping is possible. |
|
Actually, we escaped it by hand... But the code works only with PHP 5 and there are no plans for upgrade. |
kamil-tekiela
pushed a commit
to kamil-tekiela/php-src
that referenced
this pull request
Apr 4, 2021
`xmlNewNs()` does not XML encode the passed `href`, so we need to do that manually. Closes phpGH-6804. Signed-off-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlNewNs()does not XML encode the passedhref, so we need to dothat manually.