Skip to content

fix misspelled method names#6452

Closed
realFlowControl wants to merge 1 commit intophp:PHP-8.0from
realFlowControl:patch-1
Closed

fix misspelled method names#6452
realFlowControl wants to merge 1 commit intophp:PHP-8.0from
realFlowControl:patch-1

Conversation

@realFlowControl
Copy link
Copy Markdown
Contributor

Hey there 🖖

by going through php/php-tasks#26 I found that these two methods actually are named registerProgressCallback and registerCancelCallback instead of setProgressCallback and setCancelCallback. See also php/doc-en#228 (comment)

/Flo

Copy link
Copy Markdown
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@php-pulls php-pulls closed this in cdd5ec7 Nov 24, 2020
@realFlowControl realFlowControl deleted the patch-1 branch November 24, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants