rename misspelled methods#228
Closed
realFlowControl wants to merge 1 commit intophp:masterfrom
realFlowControl:patch-1
Closed
rename misspelled methods#228realFlowControl wants to merge 1 commit intophp:masterfrom realFlowControl:patch-1
realFlowControl wants to merge 1 commit intophp:masterfrom
realFlowControl:patch-1
Conversation
Member
|
@remicollet can you confirm? |
Member
|
We also should fix that in https://github.com/php/php-src/blob/PHP-8.0/UPGRADING |
Contributor
Author
👍 @cmb69 created a pr at php/php-src#6452 |
Member
|
Thanks for the PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
by going through https://github.com/php/php-tasks/issues/26 I found that these two methods actually are named
registerProgressCallbackandregisterCancelCallbackinstead ofsetProgressCallbackandsetCancelCallback./Flo