Deprecations for PHP 7.3 by nikic · Pull Request #3366 · php/php-src

nikic · 2018-07-04T21:54:19Z

Implementation for https://wiki.php.net/rfc/deprecations_php_7_3 (apart from the ones linked there).

KalleZ · 2018-07-04T22:01:36Z

You can just merge the patches I wrote and linked in the RFC as apart of this PR

Majkl578 · 2018-07-05T17:38:48Z

@nikic: Hi, are you still open to proposals to include in the RFC?
I would like to suggest few more things here. It shouldn't affect the RFC itself as each proposal is to be voted on on its own.

__CLASS__ in favor of self::class (obsolete as of PHP 5.5)
~~get_class() in favor of static::class (obsolete as of PHP 5.5)~~
get_called_class() in favor of static::class (obsolete as of PHP 5.5)
array_key_exists() with object argument

nikic · 2018-07-05T18:06:27Z

@Majkl578 We can't add anything to this RFC anymore due to timing constraints, but please add your ideas to the next RFC (https://wiki.php.net/rfc/deprecations_php_7_4) so they will not be forgotten.

Majkl578 · 2018-07-05T18:10:04Z

Alright. 👍 Is it okay if I edit the RFC directly myself, adding paragraphs for each of those? Should I note myself there (as the one who proposed them)?

nikic · 2018-07-05T18:15:12Z

@Majkl578 Yeah, feel free to edit directly.

Majkl578 · 2018-07-05T18:40:34Z

Thanks, updated. (For __CLASS__, I used invisible space, otherwise underscores were interpreted by the doc engine).

I didn't include get_class() as I realized PHP still doesn't support $instance::class. 😢 Not a big deal.

nikic · 2018-07-05T19:12:44Z

@Majkl578 You can use ''%%__CLASS__%%'' to disable interpretation.

nikic · 2018-07-05T20:58:39Z

@Majkl578 Not really the place to discuss this, but you can still deprecate get_class() without an argument, which is the part that's equivalent to self::class. The use with an argument would remain.

Also my 2c, I don't think it makes sense to deprecate __CLASS__. Especially as we still keep a bunch of other magic constants around, this doesn't seem to buy us much and may increase inconsistency rather than decrease it. If we have __FUNCTION__ and __TRAIT__ -- but no __CLASS__? That seems odd.

KalleZ · 2018-07-05T21:03:25Z

I agree with @nikic here, I think CLASS should remain for consistency, some doubles are fine imo.

KalleZ · 2018-07-14T13:17:18Z

@nikic since we opted to add the new ADD_SLASHES filter for ext/filter the deprecation should be reverted and the patch for pdo_odbc.db2_instance_name should be added and we're good (looking at the current vote)

cmb69 · 2018-07-17T10:34:15Z

@nikic Is this basically good to merge (with the omission of the magic_quotes filter deprecation)? Also the pdo_odbc.db2_instance_name php.ini directive deprecation is not yet implemented. The following patch fixes the 5 failing tests under Windows:

 ext/standard/tests/file/fgetss_basic2-win32-mb.phpt  | 2 ++
 ext/standard/tests/file/fgetss_basic2-win32.phpt     | 2 ++
 ext/standard/tests/file/fgetss_variation1-win32.phpt | 2 ++
 ext/standard/tests/file/fgetss_variation3-win32.phpt | 2 ++
 ext/standard/tests/file/fgetss_variation5-win32.phpt | 2 ++
 5 files changed, 10 insertions(+)

diff --git a/ext/standard/tests/file/fgetss_basic2-win32-mb.phpt b/ext/standard/tests/file/fgetss_basic2-win32-mb.phpt
index 783e6c3edd..c875024718 100644
--- a/ext/standard/tests/file/fgetss_basic2-win32-mb.phpt
+++ b/ext/standard/tests/file/fgetss_basic2-win32-mb.phpt
@@ -8,6 +8,8 @@ if (substr(PHP_OS, 0, 3) != 'WIN') {
 ?>
 --FILE--
 <?php
+error_reporting(E_ALL & ~E_DEPRECATED);
+
 /*
  Prototype: string fgetss ( resource $handle [, int $length [, string $allowable_tags]] );
  Description: Gets line from file pointer and strip HTML tags
diff --git a/ext/standard/tests/file/fgetss_basic2-win32.phpt b/ext/standard/tests/file/fgetss_basic2-win32.phpt
index 1fac3afb15..c7f3aa4c06 100644
--- a/ext/standard/tests/file/fgetss_basic2-win32.phpt
+++ b/ext/standard/tests/file/fgetss_basic2-win32.phpt
@@ -8,6 +8,8 @@ if (substr(PHP_OS, 0, 3) != 'WIN') {
 ?>
 --FILE--
 <?php
+error_reporting(E_ALL & ~E_DEPRECATED);
+
 /*
  Prototype: string fgetss ( resource $handle [, int $length [, string $allowable_tags]] );
  Description: Gets line from file pointer and strip HTML tags
diff --git a/ext/standard/tests/file/fgetss_variation1-win32.phpt b/ext/standard/tests/file/fgetss_variation1-win32.phpt
index 7cd49333bf..688f5e624a 100644
--- a/ext/standard/tests/file/fgetss_variation1-win32.phpt
+++ b/ext/standard/tests/file/fgetss_variation1-win32.phpt
@@ -8,6 +8,8 @@ if (substr(PHP_OS, 0, 3) != 'WIN') {
 ?>
 --FILE--
 <?php
+error_reporting(E_ALL & ~E_DEPRECATED);
+
 /*
  Prototype: string fgetss ( resource $handle [, int $length [, string $allowable_tags]] );
  Description: Gets line from file pointer and strip HTML tags
diff --git a/ext/standard/tests/file/fgetss_variation3-win32.phpt b/ext/standard/tests/file/fgetss_variation3-win32.phpt
index fc7561dff5..19699b2fb3 100644
--- a/ext/standard/tests/file/fgetss_variation3-win32.phpt
+++ b/ext/standard/tests/file/fgetss_variation3-win32.phpt
@@ -8,6 +8,8 @@ if (substr(PHP_OS, 0, 3) != 'WIN') {
 ?>
 --FILE--
 <?php
+error_reporting(E_ALL & ~E_DEPRECATED);
+
 /*
  Prototype: string fgetss ( resource $handle [, int $length [, string $allowable_tags]] );
  Description: Gets line from file pointer and strip HTML tags
diff --git a/ext/standard/tests/file/fgetss_variation5-win32.phpt b/ext/standard/tests/file/fgetss_variation5-win32.phpt
index a2d4a705e8..211c158ae2 100644
--- a/ext/standard/tests/file/fgetss_variation5-win32.phpt
+++ b/ext/standard/tests/file/fgetss_variation5-win32.phpt
@@ -8,6 +8,8 @@ if (substr(PHP_OS, 0, 3) != 'WIN') {
 ?>
 --FILE--
 <?php
+error_reporting(E_ALL & ~E_DEPRECATED);
+
 /*
  Prototype: string fgetss ( resource $handle [, int $length [, string $allowable_tags]] );
  Description: Gets line from file pointer and strip HTML tags

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

SplFileObject::fgetss() will also generate a deprecation notice through an internal call to fgetss(). Part of RFC https://wiki.php.net/rfc/deprecations_php_7_3.

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

nikic added the RFC label Jul 4, 2018

nikic force-pushed the deprecations-7.3 branch from 5928950 to d4ad0f2 Compare July 5, 2018 19:51

nikic changed the title ~~[WIP] Deprecations for PHP 7.3~~ Deprecations for PHP 7.3 Jul 5, 2018

nikic added the PHP 7.3 Nominated label Jul 5, 2018

nikic added 6 commits July 21, 2018 22:34

Deprecate undocumented mbereg_* aliases

e6016ab

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

Deprecate non-string needles in string search functions

f4a9da3

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

Deprecate defining a free-standing assert() function

5c4047b

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

Deprecate fgetss() and gzgetss()

d9acfa4

SplFileObject::fgetss() will also generate a deprecation notice through an internal call to fgetss(). Part of RFC https://wiki.php.net/rfc/deprecations_php_7_3.

Deprecate string.strip_tags filter

4a5b210

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

Deprecate pdo_odbc.db2_instance_name

fb0e8c6

Part of https://wiki.php.net/rfc/deprecations_php_7_3.

nikic force-pushed the deprecations-7.3 branch from d4ad0f2 to fb0e8c6 Compare July 21, 2018 20:40

php-pulls merged commit fb0e8c6 into php:master Jul 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecations for PHP 7.3#3366

Deprecations for PHP 7.3#3366
php-pulls merged 6 commits intophp:masterfrom
nikic:deprecations-7.3

nikic commented Jul 4, 2018 •

edited

Loading

Uh oh!

KalleZ commented Jul 4, 2018

Uh oh!

Majkl578 commented Jul 5, 2018 •

edited

Loading

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

Majkl578 commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

Majkl578 commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

KalleZ commented Jul 5, 2018

Uh oh!

KalleZ commented Jul 14, 2018

Uh oh!

cmb69 commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nikic commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KalleZ commented Jul 4, 2018

Uh oh!

Majkl578 commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

Majkl578 commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

Majkl578 commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

nikic commented Jul 5, 2018

Uh oh!

KalleZ commented Jul 5, 2018

Uh oh!

KalleZ commented Jul 14, 2018

Uh oh!

cmb69 commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nikic commented Jul 4, 2018 •

edited

Loading

Majkl578 commented Jul 5, 2018 •

edited

Loading