Json encode fail return #2101
Merged
Json encode fail return #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2013bcc to
f5b4aae
Compare
bukka
added a commit
to bukka/php-jsond
that referenced
this pull request
Feb 18, 2023
Last fixes to match php/php-src#2101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs 68992 and 70275 if
JSON_PARTIAL_OUTPUT_ON_ERRORis not set (default). The idea is that we don't need to encode the whole string if it's not used anyway and we can fail before. I plan to merge it tomorrow to 7.1 if Travis is happy and I don't find any regression.