Skip to content

Fix GH-19801: address leak when calling var_dump() with recursion in __debugInfo() #19837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexandre-daubois merged 1 commit into from
Sep 16, 2025
Merged

Fix GH-19801: address leak when calling var_dump() with recursion in __debugInfo() #19837

alexandre-daubois merged 1 commit into from
Sep 16, 2025

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Sep 15, 2025 •
edited
Loading

Fix #19801

Also fixes the same issue in debug_zval_dump(). I wasn't able to reproduce the issue with var_export() however.

Note: ext/standard/tests/general_functions/debug_zval_dump_gh19801_memory_leak.phpt should be updated on upmerge to add packed to the internal array representation

@alexandre-daubois alexandre-daubois linked an issue Sep 15, 2025 that may be closed by this pull request
var_dump() may leak dumped value #19801
Closed
@alexandre-daubois alexandre-daubois marked this pull request as ready for review September 15, 2025 09:05
@ndossche
Copy link
Member

ndossche commented Sep 15, 2025

What's wrong with zend_array_release (or similar)? Then you don't need zval wrapping

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Sep 15, 2025 •
edited
Loading

Nothing wrong apart that I forgot about it, tests still green with it on my machine. PR updated 🙂

arnaud-lb
arnaud-lb reviewed Sep 15, 2025
View reviewed changes
arnaud-lb
arnaud-lb reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@alexandre-daubois alexandre-daubois merged commit 75217c1 into php:PHP-8.3 Sep 16, 2025
9 checks passed
@alexandre-daubois alexandre-daubois deleted the vd-leak branch September 16, 2025 13:05
alexandre-daubois added a commit that referenced this pull request Sep 16, 2025
@alexandre-daubois
Merge branch 'PHP-8.3' into PHP-8.4
c569f51 
* PHP-8.3:
  Fix GH-19801: address leak when calling var_dump() with recursion in __debugInfo() (#19837)
alexandre-daubois added a commit that referenced this pull request Sep 16, 2025
@alexandre-daubois
Merge branch 'PHP-8.4'
585e581 
* PHP-8.4:
  Fix GH-19801: address leak when calling var_dump() with recursion in __debugInfo() (#19837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

var_dump() may leak dumped value

3 participants

@alexandre-daubois @ndossche @arnaud-lb