FPM: Implement configurable access log limit#18725
Closed
bukka wants to merge 1 commit intophp:masterfrom
Closed
Conversation
954e18b to
abfe22b
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jun 25, 2025
It sets the access log limit as configurable log_limit to allow larger log limit than the currently fixed limit of 1024 characters. Fixes phpGH-12302 Closes phpGH-18725
Member
Author
|
The implementation should be working now. I just need to add few more tests to test the larger limit but otherwise it's almost ready. |
It sets the access log limit as configurable log_limit to allow larger log limit than the currently fixed limit of 1024 characters. Fixes phpGH-12302 Closes phpGH-18725
abfe22b to
09b6513
Compare
Member
Author
|
I have done some testing and added extra test for increased There are actually additional limit on URI and query which were quite low so I bumped URI to 512 and query to 2048. This increases a little bit SHM as those are buffers but maybe it should be a bit more. |
Member
Author
|
I have done a bit more testing and also considered the increase of the values and think that the current increase should be sufficient for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP to implement configurable access log limit with use of the current zlog logic