Implement FR #55651: (Option to ignore the returned FTP PASV address) #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kaplanlior i'm fine with the patch, do you plan to port it for 7.0? But i've probably no conditions to test it. So if good and tested, please pull in. Thanks. |
Contributor
Author
|
I attached the 7.0 port to the bug report: https://bugs.php.net/patch-display.php?bug_id=55651&patch=ftp_usepasvaddress_php70.patch&revision=latest And yes, testing is tricky. |
|
Comment on behalf of kaplan at php.net: Merged as 90a26a4 |
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Jan 10, 2018
added in: php/php-src#1668 -- Provided by anonymous 86357 (spee.jeroen@gmail.com) git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343809 c90b9560-bf6c-de11-be94-00142212c4b1
LawnGnome
pushed a commit
to LawnGnome/phpdoc-en
that referenced
this pull request
Jan 10, 2018
added in: php/php-src#1668 -- Provided by anonymous 86357 (spee.jeroen@gmail.com) git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343809 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github
pushed a commit
to svn2github/phpdoc_en
that referenced
this pull request
Jan 10, 2018
added in: php/php-src#1668 -- Provided by anonymous 86357 (spee.jeroen@gmail.com) git-svn-id: http://svn.php.net/repository/phpdoc/en@343809 c90b9560-bf6c-de11-be94-00142212c4b1
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Sep 3, 2020
added in: php/php-src#1668 -- Provided by anonymous 86357 (spee.jeroen@gmail.com) git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343809 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch waits 4 years for review, while a lot of people complain (e.g. number of votes).
More info also at http://www.elitehosts.com/blog/php-ftp-passive-ftp-server-behind-nat-nightmare/