Fix bug GH-11941: soap with session persistence will silently fails when "seession" built as a shared object #14362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31918a0 to
eb208b5
Compare
…s when "seession" built as a shared object This adds an optional dependency on the session extension and adds the necessary APIs to make the functionality work with lazy binding. This can be tested by configuring PHP with `--enable-session=shared` and `--enable-soap=shared` and running the test suite, in particular the buggy behaviour can be observed by the existing test `server009.phpt`.
Girgias
approved these changes
May 29, 2024
Member
Girgias
left a comment
There was a problem hiding this comment.
Cannot be totally sure about SOAP but it looks sensible, session changes are OK
devnexen
reviewed
May 29, 2024
devnexen
approved these changes
May 29, 2024
drupol
added a commit
to loophp/php-src-nix
that referenced
this pull request
May 30, 2024
13 tasks
drupol
added a commit
to drupol/nixpkgs
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional dependency on the session extension and adds the necessary APIs to make the functionality work with lazy binding.
This can be tested by configuring PHP with
--enable-session=sharedand--enable-soap=sharedand running the test suite, in particular the buggy behaviour can be observed by the existing testserver009.phpt.