Fix #70103: ZipArchive::addGlob ignores remove_all_path option #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Can anybody explain this test failure? Doesn't make any sense to me. |
When the remove_all_path option is set, but no add_path option, remove_all_path is simply ignored. This patch fixes this.
Member
Author
|
Rebased onto current master to trigger the Travis checks again. |
Contributor
|
Manual test with master looks ok. Thanks. |
php-pulls
pushed a commit
that referenced
this pull request
Jan 6, 2017
* PHP-7.0: Fix #70103: ZipArchive::addGlob ignores remove_all_path option news entry for PR #1430
Member
|
Thanks :) |
php-pulls
pushed a commit
that referenced
this pull request
Jan 6, 2017
* PHP-7.1: Fix #70103: ZipArchive::addGlob ignores remove_all_path option news entry for PR #1430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the remove_all_path option is set, but no add_path option, remove_all_path
is simply ignored. This patch fixes this.
The PR is against master, but this should be merged to PHP 5.6 as well.