Callable curl options should be nullable#14165
Closed
iluuu1994 wants to merge 1 commit intophp:masterfrom
Closed
Conversation
symfony/http-client/Response/CurlResponse.php depends on this behavior.
Member
|
FYI, we fixed this in 5.4: symfony/symfony#54830. If this PR still gets merged, I'll revert 🙂 |
Member
Author
|
@alexandre-daubois Good to know! But I consider this a bug on our side. |
Girgias
approved these changes
May 7, 2024
Member
Girgias
left a comment
There was a problem hiding this comment.
Minor nit but LGTM, sorry for the break.
Member
Author
|
@alexandre-daubois Feel free to ping us in the future if there are BC breaks! Unless they are part of an RFC, they are usually not intentional, and should be discussed with the community anyway. |
Member
|
Will do for sure, thanks! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 13, 2024
…-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Revert fixing curl default options | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Reverts #54830 because php/php-src#14165 got merged and fixes the unintentional BC break. (CI still red but should go to green when new nightlies are built) Commits ------- 365f7b4 [HttpClient] Revert fixing curl default options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symfony/http-client/Response/CurlResponse.php depends on this behavior.
See https://github.com/php/php-src/actions/runs/8978207495/job/24658271316.