Skip to content

Conversation

@bukka
Copy link
Member

@bukka bukka commented Oct 15, 2023

When jpeg image with large (over stream chunk size) APP data (e.g. large metadata comment) is loaded, then not all data will be read in a single read for user stream wrapper which does not use greedy reading like for example file wrapper.

This PR makes sure that that if the whole chunk is read, then another chunk is attempted to be read until less than one chunk or whole stream is read.

@bukka bukka changed the base branch from master to PHP-8.1 October 15, 2023 15:56
@bukka bukka force-pushed the image_jpg_read_all_chunks branch from c2c2bfd to e006ad5 Compare October 15, 2023 15:57
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bukka bukka closed this in 52aa0d9 Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants