feat: multiple workers with same file #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexandre-daubois
left a comment
There was a problem hiding this comment.
I'm 👍 on this feature. Can be useful, especially given the diff to implement it! The docs should be updated as well I guess?
dunglas
approved these changes
Sep 8, 2025
Member
|
LGTM. Could you just add some docs? |
Contributor
Author
|
Yeah, will do 👍 , got some time tomorrow on the train |
….com/dunglas/frankenphp into feat/multiple-workers-with-same-path
Contributor
Author
|
Added some docs. I wonder if splitting the thread pool could also be done automatically. |
dunglas
approved these changes
Sep 9, 2025
alexandre-daubois
approved these changes
Sep 9, 2025
Member
|
Thanks! |
henderkes
pushed a commit
to static-php/frankenphp
that referenced
this pull request
Sep 11, 2025
* Allow multiple workers with the same file. * Fix formatting of duplicate filename check * Adds docs. * suggestions by @alexandre-daubois. * Update performance.md --------- Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows having multiple workers with the same entrypoint (if they match a path)
This allows splitting the worker pool, which can be useful in cases like #1796.