chore: upgrade to Go 1.25 #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like go 1.25 will now report leaks in C on program exit see here. This probably will also pick up interned strings where leaking is intentional. |
Member
Author
|
Couldn't we free them on shutdown? |
Contributor
|
We can probably free those we set ourselves (all |
Contributor
|
Seems like only disabling end-of-process leak detection will make ASAN not fail ( Since the PHP main thread is meant as one-instance-per-process, there seems to be a lot of memory that is not explicitly freed at shutdown. Which is understandable since it's inefficient to free everything at the end of the process if the OS will do it for you anyways. |
henderkes
pushed a commit
to static-php/frankenphp
that referenced
this pull request
Sep 11, 2025
* chore: upgrade to Go 1.25 * free all interned strings (test) * Revert "free all interned strings (test)" This reverts commit 34823ba. * Another test. * Another test * ASAN_OPTIONS: detect_leaks=0 * Update sanitizers.yaml * Update sanitizers.yaml * Update sanitizers.yaml --------- Co-authored-by: Alliballibaba <alliballibaba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://go.dev/doc/go1.25